feat: Possibility to use custom domain name with Cloudfront #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| }, | ||
| { | ||
| type: "input", | ||
| name: "domain", | ||
| message: "Domain for private website", | ||
| message(): string { |
There was a problem hiding this comment.
What about asking for Route53 Zone Id too so we can create the A record with CDK directly?
There was a problem hiding this comment.
That's a good point.
Most of the time Route53 public zone is centralized in an AWS Account.
This does not limits this possibility (local or central).
I propose to create another PR for this,
Domain Names and Certificates
with a migration from CloudFrontWebDistribution API
bigadsoleiman
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #298: Possibility to use custom domain name with Cloudfront
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.