Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

Updated Code to Handle few things #187

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

spatel-gfb
Copy link
Contributor

@spatel-gfb spatel-gfb commented Mar 24, 2022

Updated the templates with below :

  • updated cromwell db timeout from 5 secs to 30 secs due to issues faced.
  • updated cromwell jar with changes recently made with caching
  • added instance type options to config as per other PR raised last year (Update gwfcore-batch.template.yaml #173). Would be helpful to have that option
  • added policies for Cromwell EC2 instance to download ECR images.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Updated cromwell jar with changes recently made with caching

added instance type options to config as per other PR raised last year. Would be helpful to have that option
Copy link
Contributor

@henriqueribeiro henriqueribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wleepang wleepang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just a small comment on the default Max vCPUs for Compute Environments

src/templates/gwfcore/gwfcore-batch.template.yaml Outdated Show resolved Hide resolved
@wleepang wleepang merged commit c2f5856 into aws-samples:master Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants