feature: .NET Framework Templates #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consistent use of single quotes - Use of shorthand yaml syntax - Removed default image
- Removed unsupported container configuraitons - Updated default container image (used for initial svc deployment)
- Corrected IAM permissions, param data types - Centralized CW logs to two log groups (service/service-name) and (service/pipeline) - Added validation of zip file extension - Removed duplicate IAM perms
- ID at Execution Time Previously SSM param was resolved by using a CF parameter. This led to the SSM doc having the resolved AMI ID as the default value, not the SSM param name. This leads to essentially hard coding the AMI ID at the time that the CF stack is created. SSM doc should resolve the SSM param at time of execution. - Added Operating System Family parameter since the SSM parameter could point to an AMI ID for various OSs - Sync'd pipeline templates between public and private services
- Sync'd private and lb service templates - Corrected private template's schema
- Changed to use only the load balancer version for .NET Fx assuming that customers would move existing workloads to Windows containers as is, typically a three tier app. They wouldn't need the private version of a Fargate service since most .NET Fx workloads are monoliths and the private service implied a decomposition to microservices. We found it unlikely that customers would stick with .NET Fx if they were decomposing their application.
This is needed when using using the GitHub integration feature of Proton
echo *** was listing out the directory contents.
|
Just wanted to check in on this pull request. Been a little while since it was initiated. Any update would be appreciated. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
resolves #63
Description of changes:
This pull request includes a load balanced application hosted on a Windows ECS Fargate service with a CI/CD pipeline that follows the architecture used in the .NET Framework CI/CD for Amazon ECS AWS Quick Start
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.