Added a new pattern Resilience Backup Restore using Native AWS Services #156

prabaksa · 2023-12-21T13:30:35Z

Issue #, if available:

Description of changes: Added a new pattern Resilience Backup Restore using Native AWS Services . Added files under bin, docs and lib folders. Changed CDK Version from 2.99.1 to 2.107.0 in package.json

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…e AWS services

…e AWS Services

shapirov103 · 2023-12-21T15:23:41Z

@elamaran11 please review at your convenience.
@prabaksa I will update the libraries to use the latest CDK, you will need to merge that change.

elamaran11 · 2023-12-21T16:03:36Z

@elamaran11 please review at your convenience. @prabaksa I will update the libraries to use the latest CDK, you will need to merge that change.

Sounds good!

elamaran11 · 2023-12-21T16:13:52Z

@prabaksa Is the PR fully ready to review. Last time we spoke, i thought you were working on Architectural changes?

elamaran11

@prabaksa AWSome work. Some high level feedback:

How are we simulating failure and demonstrate the same? We should simulate failure and show the restore process.
Are you planning to run sample workload as we discussed? We need show a workload like yelb, wordpress with some state in EBS restored
package.json should be updated with latest blueprints version, cdk and all other dependencies
I think you should have single documentation demonstrating the complete DR flow.
Also the diagram in restore process is not correct, it should DR region running the workload.
destroy "*" should destroy all stack.

…ew resources

elamaran11

@prabaksa Overall looks great. AWSome work. I have some minor tactical feedback please fix this and i can run it once and merge. Also please see GH actions failing due to doc links. Please fix it all and i can run and merge.

elamaran11 · 2024-02-08T19:05:30Z

bin/resilience-br-backup-aws.ts

@@ -0,0 +1,9 @@
+import { configureApp } from '../lib/common/construct-utils';
+import ResilienceBRAWSConstruct from '../lib/resilience/backup_restore/backup/aws';


ResilienceBRAWSConstruct doesnt look like standard convention. What is BRAWS?

Backup/Restore AWS

elamaran11 · 2024-02-08T19:05:34Z

bin/resilience-br-restore-aws.ts

@@ -0,0 +1,9 @@
+import { configureApp } from '../lib/common/construct-utils';
+import ResilienceBRAWSConstruct from '../lib/resilience/backup_restore/restore/aws';


ResilienceBRAWSConstruct doesnt look like standard convention. What is BRAWS?

elamaran11 · 2024-02-08T19:06:00Z

cdk.json

@@ -1,3 +1,10 @@
 {
-  "app": "npx ts-node dist/lib/common/default-main.js"
+    "app": "npx ts-node dist/lib/common/default-main.js",


Lets remove cdk.json changes. This should go in the doc.

elamaran11 · 2024-02-08T19:23:00Z

lib/resilience/backup_restore/backup/aws/backupstack.ts

+export interface backupStackProps extends cdk.StackProps {
+    primaryKeyArn: string,
+    drbackupVault: backup.IBackupVault
+    //drbackupVault: { "backupVaultArn": string, backupVaultName: string, env: {"account": string , region: string}}


Why is this commented?

I will remove this, It is not required anymore.

elamaran11 · 2024-02-08T19:23:04Z

lib/resilience/backup_restore/backup/aws/backupstack.ts

+        super(scope, id, props );
+        const account = process.env.CDK_DEFAULT_ACCOUNT!;
+        const region = blueprints.utils.valueFromContext(scope, "resilience-backup-restore-aws.primary.region", undefined);
+        //const drregion = blueprints.utils.valueFromContext(scope, "resilience-backup-restore-aws.dr.region", undefined);


Why is this commented?

not used in this construct, will remove this earlier since everything was on a single file i had defined all the variables in the file.

elamaran11 · 2024-02-08T19:24:14Z

lib/resilience/backup_restore/restore/aws/backupstack.ts

+        super(scope, id, props );
+        const account = process.env.CDK_DEFAULT_ACCOUNT!;
+        const region = blueprints.utils.valueFromContext(scope, "resilience-backup-restore-aws.primary.region", undefined);
+        //const drregion = blueprints.utils.valueFromContext(scope, "resilience-backup-restore-aws.dr.region", undefined);


remove this.

elamaran11 · 2024-02-08T19:24:27Z

lib/resilience/backup_restore/restore/aws/drstack.ts

+
+        const  backupStackProps = {
+            primaryKeyArn: props.primaryKeyArn,
+            //drbackupVault: { "backupVaultArn": drbackupVault.attrArn, backupVaultName: drbackupVault.attrName, env: {"account": process.env.CDK_DEFAULT_ACCOUNT! , region: drregion}} 


elamaran11 · 2024-02-08T19:24:36Z

lib/resilience/backup_restore/restore/aws/index.ts

+
+
+export default class ResilienceBRAWSConstruct {
+    constructor(scope: Construct, id: string, props?: cdk.StackProps) {


'id' is defined but never used. Allowed unused args must match /^_/u

elamaran11 · 2024-02-08T19:27:38Z

lib/resilience/backup_restore/restore/aws/index.ts

+
+
+export default class ResilienceBRAWSConstruct {
+    constructor(scope: Construct, id: string, props?: cdk.StackProps) {


'props' is defined but never used. Allowed unused args must match /^_/u

elamaran11 · 2024-02-08T19:28:19Z

lib/resilience/backup_restore/restore/aws/index.ts

+            pendingWindowInDays: 30
+        });
+
+        const kmsAlias = new kms.CfnAlias(stack, 'KMSAlias', {


elamaran11

One more Comment. We need to Bootstrap the Argo right. We need an env and env maps to teams and we will have separate ArgoConfig. Check this example -

cdk-eks-blueprints-patterns/lib/multi-account-monitoring/pipeline.ts

Line 141 in b6ad0ca

    
           function createArgoAddonConfig(environment: string, repoUrl: string): blueprints.ArgoCDAddOn {

elamaran11 · 2024-02-09T13:32:02Z

lib/resilience/backup_restore/backup/aws/index.ts

+            new blueprints.addons.KubeProxyAddOn(),
+            new blueprints.addons.AwsLoadBalancerControllerAddOn(),
+            new blueprints.addons.ArgoCDAddOn({
+                bootstrapRepo: {


We dont bootstrap Argo like this. We need an env and env maps to teams and we will have separate ArgoConfig. Check this example -

cdk-eks-blueprints-patterns/lib/multi-account-monitoring/pipeline.ts

Line 141 in b6ad0ca

function createArgoAddonConfig(environment: string, repoUrl: string): blueprints.ArgoCDAddOn {

elamaran11 · 2024-02-09T13:32:16Z

lib/resilience/backup_restore/restore/aws/index.ts

+            new blueprints.addons.KubeProxyAddOn(),
+            new blueprints.addons.AwsLoadBalancerControllerAddOn(),
+            new blueprints.addons.ArgoCDAddOn({
+                bootstrapRepo: {


We dont bootstrap Argo like this. We need an env and env maps to teams and we will have separate ArgoConfig. Check this example -

cdk-eks-blueprints-patterns/lib/multi-account-monitoring/pipeline.ts

Line 141 in b6ad0ca

function createArgoAddonConfig(environment: string, repoUrl: string): blueprints.ArgoCDAddOn {

shapirov103

@prabaksa do you mind throwing a 30 min meeting to discuss the design here? I see a bunch of CDK stacks outside of the blueprints and also shell scripts. The objective of the meeting is to review the design and find the opps to improve customer experience.

github-actions · 2024-05-13T00:15:35Z

This PR has been automatically marked as stale because it has been open 60 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions · 2024-07-12T00:15:49Z

Pull request closed due to inactivity.

EC2 Default User added 5 commits December 19, 2023 15:14

Added new resilience pattern backup-restore aws

cdea896

Added Resilience Backup/Restore Native AWS Pattern

4aee122

Added new pattern under resilience category backup/restore with nativ…

714240c

…e AWS services

Added new pattern under resilience category backup/restore with nativ…

dafb9ed

…e AWS Services

Fixed Liniting issues

f13e653

shapirov103 requested a review from elamaran11 December 21, 2023 15:22

elamaran11 reviewed Dec 21, 2023

View reviewed changes

EC2 Default User and others added 10 commits December 22, 2023 07:27

Updated Documentation

ca0476e

updated documentation

193f7a3

Updated to attach KMS policy to CSI Storage Controller SA

4295702

Cleaned-up Verbose Messages

5dfd457

updated documentation

3190d2b

Added logic to check existing policies and create a policy only for n…

9f7ebaa

…ew resources

Updated DR Documentation

339847a

package.json synced with aws-samples repo

8b7b0d1

Merge branch 'aws-samples:main' into main

cb25a85

update reference to sample app in the docs

583e9b3

elamaran11 requested changes Feb 8, 2024

View reviewed changes

elamaran11 requested changes Feb 9, 2024

View reviewed changes

shapirov103 requested changes Feb 12, 2024

View reviewed changes

github-actions bot added the stale label May 13, 2024

github-actions bot closed this Jul 12, 2024

elamaran11 removed the stale label Aug 14, 2024

elamaran11 reopened this Aug 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a new pattern Resilience Backup Restore using Native AWS Services #156

Added a new pattern Resilience Backup Restore using Native AWS Services #156

prabaksa commented Dec 21, 2023

shapirov103 commented Dec 21, 2023

elamaran11 commented Dec 21, 2023

elamaran11 commented Dec 21, 2023

elamaran11 left a comment •

edited

Loading

elamaran11 left a comment

elamaran11 Feb 8, 2024

prabaksa Feb 9, 2024

elamaran11 Feb 8, 2024

elamaran11 Feb 8, 2024

prabaksa Feb 9, 2024

elamaran11 Feb 8, 2024

prabaksa Feb 9, 2024

elamaran11 Feb 8, 2024

prabaksa Feb 9, 2024

elamaran11 Feb 8, 2024

elamaran11 Feb 8, 2024

elamaran11 Feb 8, 2024

elamaran11 Feb 8, 2024

elamaran11 Feb 8, 2024

elamaran11 left a comment

elamaran11 Feb 9, 2024

elamaran11 Feb 9, 2024

shapirov103 left a comment

github-actions bot commented May 13, 2024

github-actions bot commented Jul 12, 2024

		@@ -0,0 +1,9 @@
		import { configureApp } from '../lib/common/construct-utils';
		import ResilienceBRAWSConstruct from '../lib/resilience/backup_restore/backup/aws';



		export default class ResilienceBRAWSConstruct {
		constructor(scope: Construct, id: string, props?: cdk.StackProps) {

Added a new pattern Resilience Backup Restore using Native AWS Services #156

Are you sure you want to change the base?

Added a new pattern Resilience Backup Restore using Native AWS Services #156

Conversation

prabaksa commented Dec 21, 2023

shapirov103 commented Dec 21, 2023

elamaran11 commented Dec 21, 2023

elamaran11 commented Dec 21, 2023

elamaran11 left a comment • edited Loading

Choose a reason for hiding this comment

elamaran11 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elamaran11 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shapirov103 left a comment

Choose a reason for hiding this comment

github-actions bot commented May 13, 2024

github-actions bot commented Jul 12, 2024

elamaran11 left a comment •

edited

Loading