Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add patterns for argo addon management #59

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

starchx
Copy link

@starchx starchx commented Jan 31, 2023

Issue #, if available:

Description of changes:

Added two patterns for ArgoCD addon management.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@starchx
Copy link
Author

starchx commented Jan 31, 2023

CI is failing because the depending feature is not released: aws-quickstart/cdk-eks-blueprints#588 . Will update this PR once the PR is merged.

@starchx
Copy link
Author

starchx commented Mar 12, 2023

@shapirov103 This PR added two patterns as examples of using GitOps addons.

Copy link
Contributor

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starchx looks great as far as code. I do want to have some GTM component for this as well. Let's add the pattern description to the documentation README.md and under docs/patterns. We will be converting it to mkdocs and publish on gh pages soon.

I am running validations on both patterns now.

});

// AddOns for the cluster.
const addOns: Array<blueprints.ClusterAddOn> = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all add-ons worked fine. What is the list of supported add-ons atm? Don't expect you to remember on top of your head, but if you can point to some that are not supported, don't work, please let me know.

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 60 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 18, 2023
@elamaran11
Copy link
Contributor

@starchx There is no traction on this PR for 6 months now. Could you please work on this if this feature is still needed.?

@github-actions github-actions bot removed the stale label Sep 16, 2023
Copy link

This PR has been automatically marked as stale because it has been open 60 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@elamaran11
Copy link
Contributor

@starchx There is no traction on this PR for 9 months now. Could you please work on this if this feature is still needed.?

Copy link

This PR has been automatically marked as stale because it has been open 60 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@elamaran11
Copy link
Contributor

@starchx There is no traction on this PR for 9 months now. Could you please work on this if this feature is still needed.?

Copy link

This PR has been automatically marked as stale because it has been open 60 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants