Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: EKS Pod Identity lab #789

Merged
merged 11 commits into from
Feb 14, 2024
Merged

new: EKS Pod Identity lab #789

merged 11 commits into from
Feb 14, 2024

Conversation

ashoksrirama
Copy link
Contributor

@ashoksrirama ashoksrirama commented Jan 8, 2024

What this PR does / why we need it: Demonstrate new EKS Pod Identity Functionality

Which issue(s) this PR fixes:

Fixes #764

Quality checks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit 39f09ba
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/65cc1bfae373010008d01dd2
😎 Deploy Preview https://deploy-preview-789--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@niallthomson
Copy link
Contributor

To align with our intent in #714 lets install the pod identity addon using the CLI instead of Terraform. You can see an example of where we've done this in the EBS lab https://www.eksworkshop.com/docs/fundamentals/storage/ebs/ebs-csi-driver

@ashoksrirama ashoksrirama changed the title EKS Pod Identity Module [DONT MERGE YET] EKS Pod Identity Module Jan 9, 2024
@ashoksrirama
Copy link
Contributor Author

To align with our intent in #714 lets install the pod identity addon using the CLI instead of Terraform. You can see an example of where we've done this in the EBS lab https://www.eksworkshop.com/docs/fundamentals/storage/ebs/ebs-csi-driver

Fixed

@niallthomson niallthomson added this to the Release 01/24 milestone Jan 10, 2024
@niallthomson niallthomson changed the title EKS Pod Identity Module new: EKS Pod Identity lab Jan 10, 2024
@niallthomson
Copy link
Contributor

Looks good to me. @rodrigobersa let us if you're good for this to merge.

Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready @niallthomson !

@niallthomson
Copy link
Contributor

Thanks everyone!

@niallthomson niallthomson merged commit 31c097f into aws-samples:main Feb 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS Pod Identity lab
3 participants