Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set EKS cluster name in Terraform self-service instructions #795

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

progerjkd
Copy link
Contributor

@progerjkd progerjkd commented Jan 19, 2024

export EKS_CLUSTER_NAME

What this PR does / why we need it:

Add the required step to define EKS_CLUSTER_NAME.

Which issue(s) this PR fixes:

Missing variable definition for EKS_CLUSTER_NAME.
Fixes #

Quality checks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

export EKS_CLUSTER_NAME
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit 8ae8631
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/65a9c3ccee704d000830d65d
😎 Deploy Preview https://deploy-preview-795--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@progerjkd
Copy link
Contributor Author

make test module="autoscaling"

@bryanmorganoverbey
Copy link

I may open another PR for this, but while we are at it, it would help to go ahead and set the kube config file properly after adding the terraform resources:
aws eks --region us-east-2 update-kubeconfig --name eks-workshop

This isn't mentioned in the docs, but it is a necessary step

@niallthomson niallthomson changed the title Update using-terraform.md fix: Set EKS cluster name in Terraform self-service instructions Apr 26, 2024
@niallthomson niallthomson added this to the Release 04/26 milestone Apr 26, 2024
@niallthomson niallthomson merged commit 3fbed67 into aws-samples:main Apr 26, 2024
5 checks passed
niallthomson pushed a commit that referenced this pull request Apr 27, 2024
niallthomson pushed a commit that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants