Bump cdk packages #269
Merged
Bump cdk packages #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace banner text
Co-authored-by: Imaya Kumar Jagannathan <ijaganna@amazon.com> Co-authored-by: Rafael Pereyra <rapg@amazon.com>
Add use case files See merge request observability-bd-projects/one-observability-demo!149
Bumped version CDK due python deprecation in EKS modules (#267) See merge request observability-bd-projects/one-observability-demo!150
* origin/main: (22 commits) Add use case files Bumped version CDK due python deprecation in EKS modules (#267) Bumped version CDK due python deprecation in EKS modules Replace banner text Removed CDK Nag dependencies update deps revert dependencies dotnet7 Update services.ts to include a specific addonVersion update deps revert dependencies dotnet7 Removed Fluentbit dashboard after oteladdon Enabling AWS Observbility Enhanced monitoring for EKS and removed manifests update deps revert dependencies dotnet7 Added Application insights module code Bump staging to main (#254) update deps ...
bonclay7
commented
Mar 6, 2024
| # | ||
| #------------------------------------------------------------------------------ | ||
| --- | ||
| AWSTemplateFormatVersion: '2023-10-10' |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
AWSTemplateFormatVersion only valid value is 2010-09-09
| # Lambda log group to store the fake logs in (ensures it will be deleted on stack deletion) | ||
| # Note: can't change the path for the lambda to log to | ||
| #------------------------------------------------- | ||
| LambdaLogGroup: |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The default action when replacing/removing a resource is to delete it. Set explicit values for UpdateReplacePolicy / DeletionPolicy on potentially stateful resource: Resources/LambdaLogGroup
rafaelpereyra
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.