Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reading of a parameter in the "deploy-s3-dist.sh" script #20

Closed
karolmalinski opened this issue Feb 28, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@karolmalinski
Copy link

Description
The script deploy-s3-dist.sh reads parameter --single-region incorrectly.
The parameter does not have any value, so the loop needs to pass only the key. Now it calls shift twice and as the result the parameters passed after that are read incorrectly.

Current situation

      -r|--single-region)
      SINGLE_REGION=true
      shift # past argument
      shift # past value
      ;;

Expected behavior

      -r|--single-region)
      SINGLE_REGION=true
      shift # past key
      ;;

Version: v3.0.0

@karolmalinski karolmalinski added the bug Something isn't working label Feb 28, 2023
karolmalinski added a commit to karolmalinski/media2cloud-on-aws that referenced this issue Feb 28, 2023
@raulmlamzn
Copy link

Thank you for your suggestion. We have added this request to our backlog for this solution.

@e-thoman
Copy link
Contributor

e-thoman commented Sep 5, 2023

Thanks for letting us know - this should be fixed in the release that came out today

@e-thoman e-thoman closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants