fix default settings overwriting template settings

[toufali]

Description of changes:
It appears the hard-coded default settings overwrite the templates created in MediaConvert. For example, specifying a MediaConvert CMAF template with segment length of 5 seconds gets overwritten by the CMAF default of 30 seconds.

It appears code was added to handle the case of custom template settings, however, this should apply to all templates specified in MediaConvert. MediaConvert template settings should take precedence over hard-coded settings in the encode lambda. By removing the conditional, this has the desired effect for my use-case.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[tomnight]

Thanks for this, makes total sense. We will review the PR in the next release.

[morjoan]

Fix has been put in version 5.2 to avoid overwriting template settings. Thanks for the feedback.

[RaeesBhatti]

@tomgilman I think there's been a slight oversight here. The function call to mergeSettingsWithDefault provides 3 parameters but the function expects only 2. This results in custom group always being ignored because it's the third parameter.

[eggoynes]

Hi @RaeesBhatti

Thank you for pointing this out. We can fix that in our next release.

[jilladams]

Tracking the remaining change to fix that function in a new issue.