Adding configuration to use S3 Sig V4 for presigned URLs #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configuration values, signature_version and addressing_style to ensure SigV4 is used instead of SigV2 which is an older and less secure way to access S3 with presigned URLs
|
Thanks for the feedback, we will add this to our backlog and review it in the next release. |
|
Thanks again for this feedback. This requested config has been incorporated in to the version 5.2.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration values, signature_version and addressing_style to ensure SigV4 is used instead
of SigV2 which is an older and less secure way to access S3 with presigned URLs
Issue #, if available:
#110
Description of changes:
Adding a config object to specify the use of s3v4 signature version.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.