Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CBMC proofs #94

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Upgrade CBMC proofs #94

merged 4 commits into from
Oct 15, 2021

Conversation

feliperodri
Copy link
Contributor

@feliperodri feliperodri commented Oct 13, 2021

Issue #, if available:
N/A.

Description of changes:

Upgrade to the latest version of CBMC templates and Litani (build system used by CBMC proofs). We also don't need to use mallocCanFail anymore. CBMC non-deterministically fails malloc when invoked with --malloc-may-fail and --malloc-fail-null flags (see Makefile.common).

I suggest reviewers to review this PR commit by commit (too many files changing).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri feliperodri added the enhancement New feature or request label Oct 13, 2021
@feliperodri feliperodri self-assigned this Oct 13, 2021
@karkhaz
Copy link
Contributor

karkhaz commented Oct 13, 2021

Suggest to hold off for ~1 hour, I'm about to make a new litani release with a helpful user-facing feature

@karkhaz
Copy link
Contributor

karkhaz commented Oct 13, 2021

Never mind, please feel free to merge when you have approval. I'd rather not block here.

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri feliperodri requested a review from a team October 15, 2021 16:04
@dan4thewin dan4thewin merged commit a6918ed into aws:main Oct 15, 2021
@feliperodri feliperodri deleted the upgrade-cbmc-proofs branch October 15, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants