Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt missing in PyPI source release #13

Closed
BastianZim opened this issue Feb 16, 2021 · 2 comments · Fixed by #14
Closed

requirements.txt missing in PyPI source release #13

BastianZim opened this issue Feb 16, 2021 · 2 comments · Fixed by #14
Assignees

Comments

@BastianZim
Copy link

BastianZim commented Feb 16, 2021

Hi,

the setup.py file currently gets the necessary requirements from requirements.txt as specified here:

REQUIREMENTS = [i.strip() for i in open("requirements.txt").readlines()]

This is not included with the source release in PyPI which makes building from source impossible.

Would it be possible to include that again to be able to build without using the wheel?

I noticed this because I maintain the conda-forge feedstock for this and it was caught in our CI, as can be seen here: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=278441&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

Edit: This has was caught in the CI but I was able to verify this locally as well.

@gimki gimki self-assigned this Feb 17, 2021
gimki pushed a commit that referenced this issue Feb 17, 2021
@gimki gimki linked a pull request Feb 17, 2021 that will close this issue
@gimki gimki closed this as completed in #14 Feb 17, 2021
gimki added a commit that referenced this issue Feb 17, 2021
New release includes change for #13
@gimki
Copy link
Contributor

gimki commented Feb 17, 2021

Released

@BastianZim
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants