Fix TestDockerStateToContainerState integ test.

During the workflow of TestDockerStateToContainerState, it starts a container and checks whether it's running by inspecting it. However, the container it starts exit immediately, so it's possible that when we check whether the container is running it's already stopped. This leads to flakey test as per #1899. Fixing by letting the container keep running rather than exit itself.

agent/engine/common_unix_integ_test.go

@@ -31,6 +31,12 @@ func createTestContainer() *apicontainer.Container {
 	return createTestContainerWithImageAndName(testRegistryImage, "netcat")
 }
 
+// getLongRunningCommand returns the command that keeps the container running for the container
+// that uses the default integ test image (amazon/amazon-ecs-netkitten for unix)
+func getLongRunningCommand() []string {
+	return []string{"-loop=true"}
+}
+
 func isDockerRunning() bool {
 	_, err := os.Stat("/var/run/docker.sock")
 	return err == nil

agent/engine/engine_integ_test.go

@@ -127,6 +127,10 @@ func TestDockerStateToContainerState(t *testing.T) {
 	testTask := createTestTask("test_task")
 	container := testTask.Containers[0]
 
+	// let the container keep running to prevent the edge case where it's already stopped when we check whether
+	// it's running
+	container.Command = getLongRunningCommand()
+
 	client, err := sdkClient.NewClientWithOpts(sdkClient.WithHost(endpoint), sdkClient.WithVersion(sdkclientfactory.GetDefaultVersion().String()))
 	require.NoError(t, err, "Creating go docker client failed")
 

agent/engine/engine_windows_integ_test.go

@@ -66,6 +66,12 @@ func createTestContainer() *apicontainer.Container {
 	}
 }
 
+// getLongRunningCommand returns the command that keeps the container running for the container
+// that uses the default integ test image (microsoft/windowsservercore for windows)
+func getLongRunningCommand() []string {
+	return []string{"ping", "-t", "localhost"}
+}
+
 func createTestHostVolumeMountTask(tmpPath string) *apitask.Task {
 	testTask := createTestTask("testHostVolumeMount")
 	testTask.Volumes = []apitask.TaskVolume{{Name: "test-tmp", Volume: &taskresourcevolume.FSHostVolume{FSSourcePath: tmpPath}}}