fix case sensitivity of removed image check

aws · Apr 29, 2019 · 811fbcc · 811fbcc
1 parent aabe65e
commit 811fbcc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/agent/engine/docker_image_manager.go b/agent/engine/docker_image_manager.go
@@ -538,7 +538,7 @@ func (imageManager *dockerImageManager) deleteImage(ctx context.Context, imageID
 	seelog.Infof("Removing Image: %s", imageID)
 	err := imageManager.client.RemoveImage(ctx, imageID, dockerclient.RemoveImageTimeout)
 	if err != nil {
-		if strings.Contains(err.Error(), imageNotFoundForDeletionError) {
+		if strings.Contains(strings.ToLower(err.Error()), imageNotFoundForDeletionError) {
 			seelog.Errorf("Image already removed from the instance: %v", err)
 		} else {
 			seelog.Errorf("Error removing Image %v - %v", imageID, err)

diff --git a/agent/engine/docker_image_manager_test.go b/agent/engine/docker_image_manager_test.go
@@ -1118,7 +1118,7 @@ func TestDeleteImageNotFoundError(t *testing.T) {
 	}
 	imageState, _ := imageManager.getImageState(imageInspected.ID)
 	client.EXPECT().RemoveImage(gomock.Any(), container.Image, dockerclient.RemoveImageTimeout).Return(
-		errors.New("no such image: " + container.Image))
+		errors.New("No such image: " + container.Image))
 	ctx, cancel := context.WithCancel(context.TODO())
 	defer cancel()
 	imageManager.deleteImage(ctx, container.Image, imageState)