Use url.Parse instead of strings.Replace

aws · Jul 21, 2017 · bc27acb · bc27acb
1 parent d9c026b
commit bc27acb
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/agent/wsclient/client_test.go b/agent/wsclient/client_test.go
@@ -15,8 +15,8 @@ package wsclient
 
 import (
 	"io"
+	"net/url"
 	"os"
-	"strings"
 	"testing"
 
 	"github.com/aws/amazon-ecs-agent/agent/acs/model/ecsacs"
@@ -171,9 +171,10 @@ func TestHandleIncorrectURLScheme(t *testing.T) {
 	mockServer.StartTLS()
 	defer mockServer.Close()
 
-	mockServerURL := strings.Replace(mockServer.URL, "https", "notaparticularlyrealscheme", 1)
+	mockServerURL, _ := url.Parse(mockServer.URL)
+	mockServerURL.Scheme = "notaparticularlyrealscheme"
 
-	cs := getClientServer(mockServerURL)
+	cs := getClientServer(mockServerURL.String())
 	err := cs.Connect()
 
 	assert.Error(t, err, "Expected error for incorrect URL scheme")