Skip sending internal task events to ECS control plane

aws · Jun 29, 2023 · f6bd9a9 · f6bd9a9
1 parent d8d984b
commit f6bd9a9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/agent/eventhandler/task_handler_types.go b/agent/eventhandler/task_handler_types.go
@@ -79,6 +79,11 @@ func (event *sendableEvent) taskShouldBeSent() bool {
 		return false
 	}
 
+	//  internal task state change does not need to be sent
+	if tevent.Task.IsInternal {
+		return false
+	}
+
 	// Task event should be sent
 	if tevent.Task.GetSentStatus() < tevent.Status {
 		return true

diff --git a/agent/eventhandler/task_handler_types_test.go b/agent/eventhandler/task_handler_types_test.go
@@ -61,6 +61,16 @@ func TestShouldTaskEventBeSent(t *testing.T) {
 		event        *sendableEvent
 		shouldBeSent bool
 	}{
+		{
+			// We don't send a task event to backend if it is an internal task
+			event: newSendableTaskEvent(api.TaskStateChange{
+				Status: apitaskstatus.TaskRunning,
+				Task: &apitask.Task{
+					IsInternal: true,
+				},
+			}),
+			shouldBeSent: false,
+		},
 		{
 			// We don't send a task event to backend if task status == NONE
 			event: newSendableTaskEvent(api.TaskStateChange{