Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gomock to make use of MinTimes() #429

Closed
aaithal opened this issue Jun 15, 2016 · 1 comment
Closed

Upgrade gomock to make use of MinTimes() #429

aaithal opened this issue Jun 15, 2016 · 1 comment
Assignees
@samuelkarp
Labels
kind/enhancement

Comments

@aaithal
Copy link
Contributor

aaithal commented Jun 15, 2016

Upgrade gomock to pull in the 'number of times a call is expected' commit. Use MinTimes() as per comments in #428.
@samuelkarp samuelkarp self-assigned this Jun 15, 2016
aaithal added a commit to aaithal/amazon-ecs-agent that referenced this issue Apr 4, 2017
@aaithal
engine: use MinTimes instead of AnyTimes.
020d619 
This fixes all the outstanding TODO's to migrate the test code
to using MinTimes instead of AnyTimes.

Should resolve aws#429
@aaithal aaithal mentioned this issue Apr 5, 2017
Merged
8 tasks
@aaithal
Copy link
Contributor Author

aaithal commented Apr 5, 2017

Fixed with #752

@aaithal aaithal closed this as completed Apr 5, 2017
petderek pushed a commit to petderek/amazon-ecs-agent that referenced this issue Apr 7, 2017
@aaithal @petderek
engine: use MinTimes instead of AnyTimes.
458c657 
This fixes all the outstanding TODO's to migrate the test code
to using MinTimes instead of AnyTimes.

Should resolve aws#429
jwerak pushed a commit to appuri/amazon-ecs-agent that referenced this issue Jun 8, 2017
@aaithal @jwerak
engine: use MinTimes instead of AnyTimes.
403fc14 
This fixes all the outstanding TODO's to migrate the test code
to using MinTimes instead of AnyTimes.

Should resolve aws#429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuelkarp samuelkarp

Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samuelkarp @aaithal @petderek