Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dockerfile HEALTHCHECK of agent #800

Closed
jhmartin opened this issue May 11, 2017 · 4 comments
Closed

Support Dockerfile HEALTHCHECK of agent #800

jhmartin opened this issue May 11, 2017 · 4 comments

Comments

@jhmartin
Copy link

jhmartin commented May 11, 2017

Docker 1.12 and newer supports a HEALTHCHECK directive that allows the docker daemon to detect the health of an application inside a container. Please consider adding one to the agent Dockerfile.

Docs: https://docs.docker.com/engine/reference/builder/#healthcheck

@samuelkarp
Copy link
Contributor

Hi @jhmartin, thanks for reaching out. This issue is a duplicate of #534, and discussion is happening there. If you have any comments to add to the discussion, please add it on #534. Thanks!

@jhmartin
Copy link
Author

jhmartin commented May 11, 2017

@samuelkarp It is different. #534 suggests allowing the ecs-agent to use the HEALTHCHECK output in place of the A/ELB healthchecks to detect the state of containers managed by ECS.

This issue is for the ECS to include a HEALTHCHECK directive for itself.

@samuelkarp
Copy link
Contributor

Ah, I think I missed that in your description. My apologies for the premature close.

The agent's Dockerfile is here if you're interested in making a contribution.

@cyastella
Copy link
Contributor

cyastella commented Nov 15, 2019

Closing issue since a new set of amis have been released and can be tracked here
The agent v1.33 here now support this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants