Support Dockerfile HEALTHCHECK of agent #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of mounting in another binary, can you extend the existing |
|
|
fenxiong
reviewed
Nov 6, 2019
fenxiong
approved these changes
Nov 7, 2019
suneyz
approved these changes
Nov 7, 2019
yumex93
reviewed
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address #800. Previously, ECS does not have a Healthcheck directive for itself. This PR add the healthcheck in the dockerfile to enable detect the health status of ECS agent.
Implementation details
Enable ECS agent healthcheck flag
Add the healthcheck command in the dockerfile.
Testing
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.