Fix flaky test TestGetTaskByArn and TestMetadataFileUpdatedAgentRestart #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
approved these changes
Oct 24, 2017
|
Can you please edit your commit message to be more on the lines of what was discussed here? |
TestGetTaskByArn and TestMetadataFileUpdatedAgentRestart sometimes can be flaky due to missing docker api call, as there is no way to stop the engine from procssing the task. By modifying the desired/known status of the container/task to reduce this calls.
This was referenced Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1020 #1028
Implementation details
For
TestGetTaskByArn, set the task desired status to be stopped, so there won't be any docker api call.For
TestMetadataFileUpdatedAgentRestartset the container status to running, so no pull/create/start call to docker, and added expect forForceSave.Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License: