register agent with "none" log driver capability #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent registers itself as being capable of placing containers with "none" logging driver on start, without the need for explicitly specifying this in the config
changed min docker version required to 1.19
jhaynes
approved these changes
Oct 30, 2017
richardpen
approved these changes
Oct 30, 2017
aaithal
added a commit
to aaithal/amazon-ecs-init
that referenced
this pull request
Oct 30, 2017
This commit modifies the `ECS_AVAILABLE_LOGGING_DRIVERS` env var for the Agent to include `none` logging driver. This compliments aws/amazon-ecs-agent#1041 PR in the ECS Agent repository.
2 tasks
aaithal
added a commit
to aaithal/amazon-ecs-init
that referenced
this pull request
Oct 30, 2017
This commit modifies the `ECS_AVAILABLE_LOGGING_DRIVERS` env var for the Agent to include `none` logging driver. This compliments aws/amazon-ecs-agent#1041 PR in the ECS Agent repository.
aaithal
added a commit
to aws/amazon-ecs-init
that referenced
this pull request
Oct 30, 2017
This commit modifies the `ECS_AVAILABLE_LOGGING_DRIVERS` env var for the Agent to include `none` logging driver. This compliments aws/amazon-ecs-agent#1041 PR in the ECS Agent repository.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent registers itself as being capable of placing containers
with "none" logging driver on start, without the need for
explicitly specifying this in the config
Summary
register agent with "none" log driver capability
Implementation details
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes: Yes
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License: