Fix the bug where container state change was not submitted under race condition #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpen
force-pushed
the
statechange-fix
branch
from
9f536ef
to
ac62aa7
Compare
richardpen
force-pushed
the
statechange-fix
branch
from
ac62aa7
to
787fab2
Compare
jhaynes
approved these changes
Nov 10, 2017
vsiddharth
reviewed
Nov 10, 2017
agent/api/ecsclient/client_test.go
Outdated
| @@ -696,3 +695,42 @@ func TestSubmitTaskStateChangeWithoutAttachments(t *testing.T) { | |||
| }) | |||
| assert.NoError(t, err, "Unable to submit task state change with no attachments") | |||
| } | |||
|
|
|||
| // TestSubmitContainerStateChangeWhileTaskInPending tests the container state chagne was submitted | |||
richardpen
force-pushed
the
statechange-fix
branch
from
787fab2
to
8c5a6ce
Compare
nmeyerhans
approved these changes
Nov 10, 2017
aaithal
approved these changes
Nov 10, 2017
This was referenced Nov 10, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the issue where container state change wasn't submitted to backend.
Implementation details
Initially container change with task status in <RUNNING state won't be submitted, this pr changes the logic to also send container statechange event the tasks status is in pending.
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
yes
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License:
yes