Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind credential listener to localhost #1105

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Conversation

samuelkarp
Copy link
Contributor

@samuelkarp samuelkarp commented Nov 21, 2017

Summary

Bind to 127.0.0.1 and set portproxy to 127.0.0.1 instead of 169.254.170.2

Implementation details

Bind to 127.0.0.1 and set portproxy to 127.0.0.1 instead of 169.254.170.2

Existing behavior is preserved for Linux just because I haven't tested all possible configurations on Linux (especially the net=bridge configuration).

Testing

  • Builds on Linux (make release)
  • Builds on Windows (go build -out amazon-ecs-agent.exe ./agent)
  • Unit tests on Linux (make test) pass
  • Unit tests on Windows (go test -timeout=25s ./agent/...) pass
  • Integration tests on Linux (make run-integ-tests) pass
  • Integration tests on Windows (.\scripts\run-integ-tests.ps1) pass
  • Functional tests on Linux (make run-functional-tests) pass
  • Functional tests on Windows (.\scripts\run-functional-tests.ps1) pass
  • Manually tested that credentials endpoint could be reached from a container
  • Manually tested that credentials endpoint could be reached on the same host
  • Manually tested that credentials endpoint could not be reached from a host in the same subnet

New tests cover the changes: no

Description for the changelog

none

Licensing

This contribution is under the terms of the Apache 2.0 License: yes

Copy link
Contributor

@ofiliz ofiliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmeyerhans nmeyerhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The powershell bits look right, but I don't know. 🤷‍♂️

Golang bits look good.

@samuelkarp samuelkarp merged commit fc7e219 into aws:windows Nov 22, 2017
@samuelkarp samuelkarp mentioned this pull request Nov 22, 2017
8 tasks
@samuelkarp samuelkarp added this to the 1.16.0 milestone Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants