Agent Binary Executable Name Change #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petderek
reviewed
Sep 13, 2018
|
i think you missed updating a few places. can you search the code base for 'agent.exe' and make sure you've updated every places? |
petderek
approved these changes
Sep 13, 2018
yhlee-aws
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the binary used for windows testing from
agenttoamazon-ecs-agentto keep the naming consistent across the codebase. It addresses the issue #1207. Corresponding changes need to be made to internal test for windows functional test to pass.Testing
The changes were tested by running against the modified internal tests in the personal account.
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passLicensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.