amazon-ecs-cni-plugin: update to rev 2018.10.0@93f4377 #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham2892
reviewed
Oct 10, 2018
| @@ -1,4 +1,4 @@ | |||
| // +build unit | |||
| // +build linux,unit | |||
There was a problem hiding this comment.
Does this mean that these tests will run only on Linux?
There was a problem hiding this comment.
yes, task networking is not supported on windows. i don't see why these code paths need to be tested on windows.
There was a problem hiding this comment.
I think agent/ecscni/plugin.go itself is not linux specific, that's why we have the tests running in both.
Can you add a note we need to change that as well and also the octokitten for windows that was updated and not needed anymore?
sharanyad
approved these changes
Oct 10, 2018
petderek
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
amazon-ecs-cni-plugin: update to rev 2018.10.0@93f4377
Implementation details
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.