Filter out propagated 'aws:' tags and remove skipped tagging test #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
approved these changes
Nov 27, 2018
| }) | ||
| // Filter out all tags "aws:" prefix | ||
| if !strings.HasPrefix(strings.ToLower(aws.StringValue(ec2Tag.Key)), awsTagPrefix) && | ||
| !strings.HasPrefix(strings.ToLower(aws.StringValue(ec2Tag.Value)), awsTagPrefix) { |
There was a problem hiding this comment.
even values with aws prefix are rejected?
There was a problem hiding this comment.
The service will still reject something with key "aws:foo" and value "bar", right? We should change this if so.
There was a problem hiding this comment.
Yes, value with aws prefix will be rejected as well, see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html#tag-restrictions
Tags with key "aws:foo" and value "bar" will be filtered out here, I added test cases.
fenxiong
approved these changes
Nov 27, 2018
|
The failing test is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is mainly to resolve issue #1704.
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passLicensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.