Merging moby branch into dev for docker SDK migration #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vendored packages for new moby clients generated new mocks for interface. minor refactor minor refactor minor refactor
Adding interface package for Docker SDK clients
Docker SDK Client factory setup
dockerapi: Support for Docker SDK Client
dockerapi: Refactored Docker Client Testing
Merge Dev into Moby
dockerapi: Migrated VolumeCreate and VolumeInspect to Docker SDK
dockerapi: Migrated VolumeRemove and APIVersion to Docker SDK
dockerapi: Migrated StopContainer to DockerSDK
dockerapi: Migrated ContainerList to Docker SDK
dockerapi: Migrated ContainerRemove to Docker SDK
dockerapi: Migrated ContainerStart to Docker SDK
dockerapi: Migrated RemoveImage to Docker SDK
dockerapi: Migrated VersionWithContext to Docker SDK
Merge branch 'dev' into moby
1) Our sdk migration used apis newer than the latest docker release, so our best choice is to rely on the master branch. 2) We needed newer versions of some other docker dependencies, such as docker/distribution. 3) Ran dep ensure
This was broken in a bad swagger run. See moby/moby@b16b125
Merge branch 'dev' into moby
Merge branch 'dev' into moby
Merge branch 'dev' into moby
Merge branch 'dev' into moby
yumex93
approved these changes
Dec 14, 2018
fenxiong
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merging Docker SDK migration branch into dev
Implementation details
Replacing go-dockerclient 3rd party package with docker vended SDK.
Testing
All code changes have unit/integ/fnl tests updated
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes: yes
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.