v3 metadata networks response for non-awsvpc tasks

[sharanyad]

Summary

v3 metadata networks response for non-awsvpc tasks was empty. Add networks response for all modes.

Implementation details

adding network metadata to v2 task/container metadata responses

Testing

• Builds on Linux (make release)
• Builds on Windows (go build -out amazon-ecs-agent.exe ./agent)
• Unit tests on Linux (make test) pass
• Unit tests on Windows (go test -timeout=30s ./agent/...) pass
• Integration tests on Linux (make run-integ-tests) pass
• Integration tests on Windows (.\scripts\run-integ-tests.ps1) pass
• Functional tests on Linux (make run-functional-tests) pass
• Functional tests on Windows (.\scripts\run-functional-tests.ps1) pass

New tests cover the changes: yes

manual testing:

curl $ECS_CONTAINER_METADATA_URI | python -mjson.tool
{
    "CreatedAt": "2019-02-04T23:09:18.482622006Z",
    "DesiredStatus": "RUNNING",
    "DockerId": "c39b3407963ca852f3f905c2739458f4bfbf5a6daa39415637d725ef651bc94d",
    "DockerName": "ecs-sleep-5-busy-sleep-aacfbbedecb6f0cde801",
    "Image": "ubuntu",
    "ImageID": "sha256:20bb25d32758db4f91b18a9581794cfaa6a8c5fbad80093e9a9e42211e131a48",
    "KnownStatus": "RUNNING",
    "Labels": {
        "com.amazonaws.ecs.cluster": "default",
        "com.amazonaws.ecs.container-name": "busy-sleep",
        "com.amazonaws.ecs.task-arn": "arn:aws:ecs:us-west-2::task/b2f909df-43e5-4717-a8c6-99905475cd03",
        "com.amazonaws.ecs.task-definition-family": "sleep",
        "com.amazonaws.ecs.task-definition-version": "5"
    },
    "Limits": {
        "CPU": 512,
        "Memory": 100
    },
    "Name": "busy-sleep",
    "Networks": [
        {
            "IPv4Addresses": [
                "172.17.0.2"
            ],
            "NetworkMode": "default"
        }
    ],
    "StartedAt": "2019-02-04T23:09:19.00245409Z",
    "Type": "NORMAL"
}

curl $ECS_CONTAINER_METADATA_URI/task | python -mjson.tool
{
    "AvailabilityZone": "us-west-2a",
    "Cluster": "default",
    "Containers": [
        {
            "CreatedAt": "2019-02-04T23:09:18.482622006Z",
            "DesiredStatus": "RUNNING",
            "DockerId": "c39b3407963ca852f3f905c2739458f4bfbf5a6daa39415637d725ef651bc94d",
            "DockerName": "ecs-sleep-5-busy-sleep-aacfbbedecb6f0cde801",
            "Image": "ubuntu",
            "ImageID": "sha256:20bb25d32758db4f91b18a9581794cfaa6a8c5fbad80093e9a9e42211e131a48",
            "KnownStatus": "RUNNING",
            "Labels": {
                "com.amazonaws.ecs.cluster": "default",
                "com.amazonaws.ecs.container-name": "busy-sleep",
                "com.amazonaws.ecs.task-arn": "arn:aws:ecs:us-west-2::task/b2f909df-43e5-4717-a8c6-99905475cd03",
                "com.amazonaws.ecs.task-definition-family": "sleep",
                "com.amazonaws.ecs.task-definition-version": "5"
            },
            "Limits": {
                "CPU": 512,
                "Memory": 100
            },
            "Name": "busy-sleep",
            "Networks": [
                {
                    "IPv4Addresses": [
                        "172.17.0.2"
                    ],
                    "NetworkMode": "default"
                }
            ],
            "StartedAt": "2019-02-04T23:09:19.00245409Z",
            "Type": "NORMAL"
        }
    ],
    "DesiredStatus": "RUNNING",
    "Family": "sleep",
    "KnownStatus": "RUNNING",
    "PullStartedAt": "2019-02-04T23:09:15.072280841Z",
    "PullStoppedAt": "2019-02-04T23:09:18.475952428Z",
    "Revision": "5",
    "TaskARN": "arn:aws:ecs:us-west-2:074626758757:task/b2f909df-43e5-4717-a8c6-99905475cd03"
}

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[sharanyad]

looks like a windows integ test(flakey, haven't seen this one before) failed - TestVolumesFromRO

[adnxn]

for my understanding -

why aren't we keeping the logic to build up the responses in response.go where the rest of the structure is constructed? it's not obvious to me why we are appending this metadata a layer above.

same question for the task response structure.

[sharanyad]

the network information is populated in v2's response.go only if the task has an ENI, since it should work only for awsvpc tasks. So I added logic here to add network response for non awsvpc tasks. let me know if that makes sense

[adnxn]

thanks for explaining the reponse.go thing

[fierlion]

nit: did you run go fmt on this?

[sharanyad]

I did and doesn't report of anything different