Fix error detection case when image that is being deleted does not exist #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenxiong
approved these changes
Feb 27, 2019
ubhattacharjya
approved these changes
Feb 27, 2019
samuelkarp
reviewed
Feb 27, 2019
|
ARM tests are failing because of nginxinc/docker-nginx#313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1871
When the agent tries to remove an image that does not exist on the instance, the error message received back by the agent is
no such image: <image name>.Agent tries to match the error message with
no such imageinstead ofno such image: <image name>. As a result, agent is not able to correctly detect that the error thrown back is because the image does not exist.Implementation details
Testing
Test
TestDeleteImageNotFoundErrormodified to mock correct error message and fails without this change in place.New tests cover the changes: yes
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.