taskresources: set terminal reason msg for all errors #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petderek
reviewed
Apr 25, 2019
| // terminalReason should be set for resource creation failures. This ensures | ||
| // the resource object carries some context for why provisoning failed. | ||
| terminalReason string | ||
| terminalReasonOnce sync.Once |
There was a problem hiding this comment.
Whats the rationale for including the sync.Once?
There was a problem hiding this comment.
hm it was in the existing codepaths that populated the terminalReason string. need to dig into the old ones to figure out why we added that in the first place 🤔
There was a problem hiding this comment.
sigh, noting outside of This field does not accept updates. here
im thinking since its a public setter for terminal reason, we didn't want the field clobbered once it's been set
adnxn
reviewed
Apr 25, 2019
sharanyad
reviewed
Apr 25, 2019
yes I will add unit tests 👍 |
sparrc
changed the title
sparrc
changed the title
closes aws#1631 return a default terminal reason remove terminalReason code for cgroups based on PR review Test that volume errors are propogated
adnxn
approved these changes
Apr 29, 2019
yhlee-aws
approved these changes
Apr 29, 2019
fierlion
added a commit
to fierlion/amazon-ecs-agent
that referenced
this pull request
Apr 30, 2019
Updating to go 1.12 Make CGroups CPU period configurable Signed-off-by: Mohamad Arab <boynux@gmail.com> taskresources: set terminal reason msg for all errors (aws#2004) * taskresources: set terminal reason msg for all errors closes aws#1631 return a default terminal reason remove terminalReason code for cgroups based on PR review Test that volume errors are propogated * fix cleanup error test and add string check Fix telemetry test for ws2019 On WS2019 functional test image mcr.microsoft.com/windows/servercore:ltsc2019, the behavior to handle path changed from ws2016 image, it needs to set entrypoint with absolute path or have entrypoint set to powershell to run executable without absolute path. Also removed unused binary in windows telemetry test. add storageReadBytes storageWriteBytes stats
fierlion
pushed a commit
to fierlion/amazon-ecs-agent
that referenced
this pull request
Apr 30, 2019
* taskresources: set terminal reason msg for all errors closes aws#1631 return a default terminal reason remove terminalReason code for cgroups based on PR review Test that volume errors are propogated * fix cleanup error test and add string check
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1631
Summary
This adds a terminal reason to all relevant errors in taskresources
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.