image manager: cleanup 'dead' and 'created' containers #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
changed the title
sparrc
changed the title
sharanyad
reviewed
May 2, 2019
agent/engine/docker_image_manager.go
Outdated
| seelog.Errorf("Error inspecting non-ECS image name: %s - %v", imageName, iiErr) | ||
| // Get the all image sizes | ||
| for _, image := range nonECSImagesRmEligible { | ||
| resp, err := imageManager.client.InspectImage(image.ImageID) |
There was a problem hiding this comment.
any reason why this was change from imageName to imageID?
Sometimes, two images can have same ID but different names. just making sure this doesn't break anything.
There was a problem hiding this comment.
The reason I changed this to image ID is because with image name we don't properly cleanup 'dangling' images (because the name is <none>). I made a comment about this here: #1684 (comment)
But that is a good catch, I did not realize two images can have the same ID but a different name. Maybe changing this behavior should be broken out into a separate issue and PR, if we want to do it at all.
There was a problem hiding this comment.
okay, I've removed the parts that removed 'dangling images'
sparrc
force-pushed
the
sparrc-1684
branch
3 times, most recently
from
788ab3a to
8372fef
Compare
sharanyad
reviewed
May 3, 2019
sharanyad
reviewed
May 3, 2019
also cleanup of 'dangling' images that have no tags or names associated with them (ie, they show as <none> in 'docker images') closes aws#1684 unit tests dont touch dangling images -- for now skip containers that don't have a finished time
sharanyad
approved these changes
May 3, 2019
fierlion
approved these changes
May 3, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also cleanup of 'dangling' images that have no tags or names associated
with them (ie, they show as in 'docker images')
see #1684
Summary
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.