Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.28.1 stage #2057

Merged
merged 19 commits into from
Jun 6, 2019
Merged

V1.28.1 stage #2057

merged 19 commits into from
Jun 6, 2019

Conversation

fenxiong
Copy link
Contributor

@fenxiong fenxiong commented May 31, 2019 •
edited
Loading

Summary

Update agent to 1.28.1. Changelog:

  • Enhancement - Non-ECS images cleanup: clean up dangling images with image ID #2023
  • Bug - Pick up latest version of amazon-vpc-cni-plugins to include recent bug fixes (f09fd7c, d90eebe)
  • Bug - Fixed error detection case when image that is being deleted does not exist @bendavies #2008
  • Bug - Fixed a bug where docker volume deletion resulted in nullpointer #2059

Implementation details

Testing

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

yhlee-aws and others added 14 commits May 13, 2019 09:17
@yhlee-aws
Removing test-artifact from codebuild makefile target, race flag is f…
6928457 
…ailing windows
@bendavies @shubham2892
fix case sensitivity of removed image check
9a5e2db
@yhlee-aws
Adding security disclosure section to README
32c9965
@yhlee-aws
updating issues template with instruction on how to report security i…
ed17c76 
…ssues
@suneyz
cni: upgrade cni to v0.7.0
1e66488
@suneyz
ecscni: Update to use the latest cni library
5a22068
@suneyz
test: fix unit test related to cni
eb7ced2
@yhlee-aws
Adding missing function for non-linux, non-windows.
7bf97ab
@sparrc
non-ECS image cleanup: cleanup dangling images
22fa19a 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
@sparrc
Makefile: fix test-silent and test-registry targets
334ba95 
makes test-silent run exactly the same as 'make test', just without '-v'

Also fix duplicate test-registry targets
@yhlee-aws
ecrauth: unify the interface for the pull credentials
41e8f5e
@fenxiong
Merge branch 'master' into dev
ef36e51
@fenxiong
Merge pull request aws#2055 from fenxiong/merge-master
c792d67 
Merge master into dev after 1.28.0 release
@yhlee-aws
Closing few TODOs in functional tests
e6e3a73
@fenxiong fenxiong requested a review from a team May 31, 2019 16:58
@fenxiong fenxiong added this to the 1.28.1 milestone May 31, 2019
@sharanyad
Copy link
Contributor

Changelog should also contain that we are deleting images by ID as well for non ECS image cleanup.

@fenxiong
Copy link
Contributor Author

fenxiong commented May 31, 2019 •
edited
Loading

Changelog should also contain that we are deleting images by ID as well for non ECS image cleanup.

Good catch thanks. Added changelog -

  • Enhancement - Non-ECS images cleanup: clean up dangling images with image ID #2023

@fenxiong fenxiong added staging Trigger staging workflow and removed staging Trigger staging workflow labels May 31, 2019
@fenxiong fenxiong added staging Trigger staging workflow and removed staging Trigger staging workflow labels Jun 4, 2019
@fenxiong fenxiong merged commit 7e013ce into aws:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhlee-aws yhlee-aws yhlee-aws approved these changes

@suneyz suneyz suneyz approved these changes

Assignees
No one assigned
Labels
staging Trigger staging workflow
Projects
None yet
Milestone
1.28.1
Development

Successfully merging this pull request may close these issues.
6 participants
@fenxiong @sharanyad @suneyz @yhlee-aws @bendavies @sparrc