Fixing Agent reports incorrect capabilities on windows (#2035) #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubhattacharjya
approved these changes
Jun 5, 2019
|
I think you need to update the windows test file agent_capability_windows_test.go to add the test case to check that we do not introduce redundant capabilities for windows. Currently, we do not have any test case there. |
yumex93
reviewed
Jun 5, 2019
| for i, expected := range expectedCapabilities { | ||
| assert.Equal(t, aws.StringValue(expected.Name), aws.StringValue(capabilities[i].Name)) | ||
| assert.Equal(t, aws.StringValue(expected.Value), aws.StringValue(capabilities[i].Value)) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you add a comment here to give a description about what this test case is doing?
yumex93
reviewed
Jun 5, 2019
| assert.NoError(t, err) | ||
| assert.Equal(t, len(expectedCapabilities), len(capabilities)) | ||
| for i, expected := range expectedCapabilities { | ||
|
|
There was a problem hiding this comment.
nit: this blank line can be removed.
mssrivas
force-pushed
the
Issues
branch
2 times, most recently
from
17665e0
to
6b77b00
Compare
yumex93
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing Agent reports incorrect capabilities on windows.
Issue - #2035
Implementation details
Implemented capabilities through methods that explicitly set it for a unix system and not for a windows
Testing
New tests cover the changes: Adding new unit tests
Verified by running following commands -
On Unix : docker run -v /var/run/docker.sock:/var/run/docker.sock amazon/amazon-ecs-agent --ecs-attributes
On Windows : aws --region us-east-1 ecs describe-container-instances --cluster window --container-instances 05ef0d5f98774e839c9e47b4158c5c57
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.