merge metrics branch to dev #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge latest dev to network-disk-metrics branch
merge 'dev' into metrics branch
The new stats added as part of the container metrics struct is sent to TCS as part of `PublishMetricsInput`
Currently, Docker does not return Network stats for ECS network modes - awsvpc, host, none. Do not send zero value network metrics to TCS for those network modes.
merge dev into network-disk-metrics branch
merge latest dev into metrics branch
merge latest dev into metrics branch
yhlee-aws
approved these changes
Jun 5, 2019
tommyhahn
approved these changes
Jun 5, 2019
fierlion
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
merging network-disk-metrics feature branch to dev branch
Implementation details
from latest dev branch,
git merge network-disk-metricsNo merge conflicts
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.