set containers DockerId per task #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suneyz
reviewed
Jul 22, 2019
sparrc
reviewed
Jul 22, 2019
sparrc
previously requested changes
Jul 22, 2019
sharanyad
reviewed
Jul 22, 2019
sharanyad
reviewed
Jul 29, 2019
suneyz
approved these changes
Aug 1, 2019
fenxiong
reviewed
Aug 1, 2019
agent/statemanager/testdata/v23/perContainerRuntimeID/ecs_agent_data.json
Outdated
Show resolved
Hide resolved
petderek
reviewed
Aug 1, 2019
sharanyad
reviewed
Aug 2, 2019
adnxn
approved these changes
Aug 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
expose container dockerId per task
Implementation details
update container runtimeId attribute to container and containerStatechange struct.
set containerDockerId when container is created.
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.