Full task sync #2191
Merged
Full task sync #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petderek
reviewed
Oct 12, 2019
| } | ||
| } | ||
|
|
||
| func (taskManifestHandler *taskManifestHandler) start() { |
There was a problem hiding this comment.
should we split this out into multiple (probably 2) handlers?
There was a problem hiding this comment.
Can be done, but they are a part of one operation(they are incomplete without each other), so will prefer to keep them together, thoughts?
fenxiong
reviewed
Oct 15, 2019
sharanyad
reviewed
Oct 16, 2019
fenxiong
reviewed
Oct 23, 2019
fenxiong
approved these changes
Oct 23, 2019
sharanyad
reviewed
Oct 24, 2019
sharanyad
approved these changes
Oct 31, 2019
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A new capability
full-syncis added which advertises that Agent can handle this new type of messages.Workflow
When the Agent connects to the ACS , ACS with send a
TaskManifesttype of message. Agent is expected to:Check for staleness: The agent will keep track of the highest timeline number received in both PayloadMessage and TaskManifestMessage. If the timeline number on TaskManifestMessage is lower to the latest known one, the TaskManifestMessage must be discarded.
If the Manifest is not stale, compare the list of tasks running on the instance to the list of RUNNING tasks in the Manifest. Tasks not present in the manifest become candidates to be stopped.
If there are stop candidates, Agent will send a TaskStopVerificationMessage to ACS, containing all the tasks it determines need to stop (stop candidates) with a desired status of STOPPED. ACS will then verify if the STOPPED tasks in the message should be terminated. ACS will reply with TaskStopVerificationAck, containing all the tasks that must be terminated with a desired status STOPPED.
The agent must terminate all tasks listed in TaskStopVerificationAck. Exceptions saying the task being terminated does not exist should be ignored. Tasks in the Manifest but NOT on the instance are simply ignored.
Implementation details
seqNumTaskManifestis added to Agent struct to keep track of latest timeline number Agent has processed.seqNumTaskManifestis stored in the state file so that it can be restored when Agent restarts.seqNumTaskManifestis updated in the state file and Agent struct, on every payload message and TaskManifest message.Testing
New tests cover the changes:yes
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.