ImageDigest only for ECR #2201
Merged
ImageDigest only for ECR #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
reviewed
Sep 12, 2019
fenxiong
reviewed
Sep 12, 2019
fenxiong
approved these changes
Sep 12, 2019
suneyz
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fetch the image RepoDigest only for ECR.
run docker images --digests
Implementation details
Testing
New tests cover the changes:
Description for the changelog
container repositories support two kinds of digests: manifest digests and index digests. Manifest digests are the digests for the manifest which represents a specific os and architecture that an image was built for.Index digests that image digest that build on top of manifest digest (we can get this from docker images —digests). When user directly pull an image from DockerHub, user get a digest as we called index digest. When the same image in ECR repo, we get the digest called manifest digest. ECR doesn’t currently support index digests, so users won’t see this behavior. Dockerhub displays the manifest digest on their website, but the index digest is what is recorded by the docker daemon. This may confuse customers which ImageDigest that they use (manifest digest or index digest).
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.