Added support for automatic spot instance draining. #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ECS_SPOT_INSTANCE_DRAINING_ENABLED configuration variable * _ENABLED->ENABLE_
* Added Spot termination poller routine * Added unit tests for ECS client: UpdateContainerInstancesState and GetResourceTags * Added unit tests ec2 metadata client: SpotTerminationTime * Added unit tests to agent: isSpotTerminationTimeSet * code review comment updates * use assert library for unit tests
* Change termination-time query to instance-action * code review fixups * more code review fixups * refactor tests to be table-driven
tommyhahn
approved these changes
Sep 13, 2019
yhlee-aws
approved these changes
Sep 16, 2019
fenxiong
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a merge of the feature branch.
Description for the changelog
Added support for automatic spot instance draining.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.