Issue a stop when start container failed with EOF error #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnxn
reviewed
Oct 23, 2019
fenxiong
force-pushed
the
test-startcontainer
branch
from
49d48ad to
f8a68b7
Compare
adnxn
approved these changes
Oct 23, 2019
When start container failed with EOF there's a chance that the container is started anyway, so issue a stop for this case.
fenxiong
force-pushed
the
test-startcontainer
branch
from
f8a68b7 to
adbf4a9
Compare
sharanyad
reviewed
Oct 23, 2019
| // a stop. See #1043 for details | ||
| shouldForceStop = true | ||
| } else if errorName == dockerapi.CannotStartContainerErrorName && strings.HasSuffix(errorStr, io.EOF.Error()) { | ||
| // If we get an EOF error from Docker when starting the container, we don't really know whether the |
There was a problem hiding this comment.
do we know when does an EOF error occur?
There was a problem hiding this comment.
From my understanding, an EOF means the client didn't read anything from the response, which can happen if the connection closes before server writes the response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1708. When start container failed with EOF, there's a chance that the container is started anyway, so issue a stop for the container in that case.
Implementation details
The stop is issued in
handleEventErroor, in the same way as how we issue a stop when start container times out. I can't find a typed error from Docker or golang for this, so check is based on the error string.Testing
Unit test added. Manually tested by injecting the error in docker client and verified that the container is forced to stop.
Description for the changelog
Fixed a bug where the agent could lose track of running containers upon certain Docker API error #2245.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.