Add new ECS_LOG_ configuration variables #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhlee-aws
reviewed
Jan 7, 2020
README.md
Outdated
| @@ -181,6 +181,10 @@ additional details on each available environment variable. | |||
| | `ECS_DISABLE_DOCKER_HEALTH_CHECK` | `false` | Whether to disable the Docker Container health check for the ECS Agent. | `false` | `false` | | |||
| | `ECS_NVIDIA_RUNTIME` | nvidia | The Nvidia Runtime to be used to pass Nvidia GPU devices to containers. | nvidia | Not Applicable | | |||
| | `ECS_ENABLE_SPOT_INSTANCE_DRAINING` | `true` | Whether to enable Spot Instance draining for the container instance. If true, if the container instance receives a [spot interruption notice](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/spot-interruptions.html), agent will set the instance's status to [DRAINING](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/container-instance-draining.html), which gracefully shuts down and replaces all tasks running on the instance that are part of a service. It is recommended that this be set to `true` when using spot instances. | `false` | `false` | | |||
| | `ECS_LOG_ROLLOVER_TYPE` | "size" | "hourly" | Determines whether the container agent logfile will be rotated based on size or hourly. By default, the agent logfile is rotated each hour. | `hourly` | `hourly` | | |||
| | `ECS_LOG_OUTPUT_FORMAT` | "logfmt" | "json" | Determines the log output format. When the json format is used, each line in the log would be a structured JSON map. | `logfmt` | `logfmt` | | |||
There was a problem hiding this comment.
nit: here for json and size, hourly for ECS_LOG_MAX_FILE_SIZE_MB, use json, hourly, size to make them stand out as config values?
yhlee-aws
approved these changes
Jan 7, 2020
fenxiong
approved these changes
Jan 7, 2020
sparrc
force-pushed
the
ecs-log-env-vars
branch
from
f639997
to
f63e5d2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding documentation to the README on environment variables used to configure new agent log features.
Implementation details
See #2311 and #2319
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.