Update sbin mount point to avoid conflict with newer Docker #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer version of Docker mounts tini to /sbin/init which conflicts our existing /sbin:/sbin mount. Updating the mount to /sbin:/host/sbin and adds /host/sbin to the PATH env (needed by the appmesh plugin to find the iptable binary) fixes the problem.
|
Thanks for doing this. Did you test this change against an older version of init? |
Yeah i launched the agent with existing version of init and ran the appmesh functional test and it passed. The old path |
|
I saw that but wanted to double check. Nice!! |
petderek
approved these changes
Jan 23, 2020
yhlee-aws
approved these changes
Jan 23, 2020
adityapahuja
added a commit
to alphagov/verify-infrastructure
that referenced
this pull request
Mar 10, 2020
This change updates docker volume mount to use /host/sbin instead of /sbin. This change is needed to avoid conflict with newer Docker. Please see further details on the following link (aws/amazon-ecs-agent#2345). Author: @adityapahuja
adityapahuja
added a commit
to alphagov/verify-infrastructure
that referenced
this pull request
Mar 10, 2020
This change updates docker volume mount to use /host/sbin instead of /sbin. This change is needed to avoid conflict with newer Docker. Please see further details on the following link (aws/amazon-ecs-agent#2345). Author: @adityapahuja
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Newer version of Docker mounts tini to /sbin/init which conflicts our existing /sbin:/sbin mount. Updating the mount to /sbin:/host/sbin and adds /host/sbin to the PATH env (needed by the appmesh plugin to find the iptable binary) fixes the problem.
This accompanies aws/amazon-ecs-init#296.
Implementation details
Update the mount from
/sbin:/sbinto/sbin:/host/sbin. Add/host/sbinto the PATH env of the agent.Testing
The appmesh cni plugin needs this mount to be correct in order to find the
iptablesexecutable, so our existing appmesh functional test will be ensuring the changes don't break the plugin. I've manually ran the test on an instance with Docker 19.03.5 and verifies that the test fails without the changes, but passes with the changes.New tests cover the changes: no
Description for the changelog
Update sbin mount point to avoid conflict with newer version of Docker.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.