Bugfix: fix windows logfile writing #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fierlion
approved these changes
Jan 29, 2020
fenxiong
approved these changes
Jan 29, 2020
| @@ -0,0 +1,258 @@ | |||
| // +build windows | |||
|
|
|||
| // Copyright 2014-2015 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
sparrc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2346
This line:
<format id="windows" format="%Msg" />was mistakenly removed in an intermediary commit during work on our logging changes. It was then re-added but the commit that added it back in was reverted to fix an unrelated bug (see #2337)This change adds this line back into our seelog config and adds windows unit tests to prevent this happening in the future.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.