Fix missing region error when using Firelens external config. #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetBucketLocation returns null for bucket in us-east-1. Return us-east-1 instead of null in that case.
yhlee-aws
approved these changes
Feb 15, 2020
mssrivas
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2354.
When fetching firelens config from S3 bucket, S3's GetBucketLocation API is used to determine the region of the bucket. This API returns null for bucket in us-east-1, so we set an empty string as region of the download client, and subsequent download fails.
Fix by returning us-east-1 as region instead of empty string when the API returns null.
I didn't see this behavior of GetBucketLocation documented anywhere so I double check a few buckets in other standard regions and BJS/ZHY, seems like only us-east-1 bucket returns null.
Implementation details
See above.
Testing
Reproduced the issue, and verified that it's fixed by this pr.
Description for the changelog
Fixed a bug where Firelens container could not use config file from S3 bucket in us-east-1.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.