retrieve envfiles from s3 concurrently using go routines #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhlee-aws
approved these changes
Mar 11, 2020
yhlee-aws
reviewed
Mar 11, 2020
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (envfile *EnvironmentFileResource) downloadEnvfileFromS3(envFilePath string, iamCredentials credentials.IAMRoleCredentials) error { | ||
| func (envfile *EnvironmentFileResource) downloadEnvfileFromS3(envFilePath string, iamCredentials credentials.IAMRoleCredentials, |
There was a problem hiding this comment.
in error cases, should we log the task id/arn or does it get logged in the method that calls this?
There was a problem hiding this comment.
the full s3 arn should get logged. should we also log the task arn?
There was a problem hiding this comment.
s3 arn doesn't provide any identifying info about for which task the env file download was attempted so yeah i think we should add it.
yumex93
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates how we retrieve envfiles from s3.
Implementation details
Each envfile specified will spin up a go routine so that multiple env files can be retrieved in parallel
Testing
New tests cover the changes: no
make testis successful. Yunhee will add a benchmark into test plan.Description for the changelog
N/A
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.