docker task manager: dont send to closed channels #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
changed the title
sparrc
changed the title
sharanyad
approved these changes
May 28, 2020
mssrivas
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Go channels do not need to be closed as a cleanup procedure. In fact, channels that are used to send data to will panic if they are closed and data is attempted to be sent (as we do in this case).
The only reason to close a channel in Go is to signal that it is closed to receivers of the channel. In the case of these channels we are not waiting on a closed channel signal.
see https://groups.google.com/forum/#!msg/golang-nuts/pZwdYRGxCIk/qpbHxRRPJdUJ
This change also uses a select statement when sending data on channels, to make sure that it doesn't hang when the manager's context has been cancelled.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.