Bug fix:Env File Feature would not accept = in value #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
approved these changes
Jun 19, 2020
ubhattacharjya
force-pushed
the
BugFixEnvFile
branch
2 times, most recently
from
fc812da
to
0e26ddb
Compare
Added test. |
yhlee-aws
approved these changes
Jun 19, 2020
ubhattacharjya
force-pushed
the
BugFixEnvFile
branch
from
0e26ddb
to
106ed6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a bug where env file feature would not accept "=", which is the delimiter in the values of a env var.
VARIABLE=abc=h would get truncated to VARIABLE=abc
Implementation details
Changed the method strings.Split(line, "=") to strings.SplitN(line, "=", 2)
Testing
Tested that the env var is correctly getting its value after this change
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.