Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.41.1 stage #2510

Merged
merged 5 commits into from
Jul 8, 2020
Merged

V1.41.1 stage #2510

merged 5 commits into from
Jul 8, 2020

Conversation

cyastella
Copy link
Contributor

Summary

1.41.1 stage

Implementation details

Testing

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cyastella cyastella added this to the 1.41.1 milestone Jul 6, 2020
CHANGELOG.md Outdated
@@ -1,5 +1,8 @@
# Changelog

## 1.41.1
* Bug - Change ports response from Ports to KnownPortBindings when present HostPort of taskMetadata endpoint response [#2495](https://github.com/aws/amazon-ecs-agent/pull/2495)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it is a bit unclear what problem we've addressed with this message. IMO we can refer to original bug report issue #2476 and use this changelog:
Fixed a bug where HostPort is not present in ECS Task Metadata Endpoint response with bridge network type #2495

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, will change it.

@yhlee-aws
Copy link
Contributor

don't forget to add bot/test label when it's ready to run tests.

@cyastella cyastella added the staging Trigger staging workflow label Jul 6, 2020
@amazon-ecs-bot amazon-ecs-bot merged commit a2cb1c4 into aws:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Trigger staging workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants