Fix response codes for container metadata and task metadata requests #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix response codes for container metadata and task metadata requests in v3 and v4.
For example: If container's network metadata is unavailable, we should return 5xx instead of 400(Bad Request) response code
Implementation details
This PR includes following changes to
agent/handlersIn/utils- added errors.go to have a Transient error type/v3and/v4- added logging and fixed response code for container and task metadatahandler requestTesting
Manually tested the changes to see if we are 500 response code is returned when container network settings is nil by commenting out
amazon-ecs-agent/agent/engine/docker_task_engine.go
Line 414 in 953af90
New tests cover the changes: no
Description for the changelog
Bug - Fix response code when container network metadata is unavailable in TMDE
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.