Explicitly initialize seelog #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
force-pushed
the
logger-init
branch
3 times, most recently
from
c5db8df
to
38b5f0b
Compare
kzys
force-pushed
the
logger-init
branch
2 times, most recently
from
5e31bb1
to
984bde2
Compare
The logger package's initialization logic is init() which will be executed by loading the package. However some of our programs are using the agent as a library and haven't configured seelog beforehand. Due to that, loading the package logs ``` 1600397429848419666 [Error] node must have children ``` which breaks the programs. I think it would be safer to do less on init() and explicitly initialize the logger from the agent's main(). Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
mssrivas
approved these changes
Oct 14, 2020
sparrc
approved these changes
Oct 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The logger package's initialization logic is init() which will be
exected by loading the package.
However some of our programs are using the agent as a library and
haven't configured seelog beforehand. Due to that, loading the package
logs
which breaks the programs.
I think it would be safer to do less on init() and explictly
initialize the logger from the agent's main().
Implementation details
Renamed logger.init() to logger.Init() and called the renamed/exported function from the agent's main().
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.